Repository navigation
Fix D3 sequence for TGL - #6725
Merged
Merged
Conversation
|
This patch seems not helpful for MTL, #6679 is still reproducible with it on MTL. |
tmleman
requested changes
Dec 6, 2022
Comment on lines
880
to
885
Contributor
There was a problem hiding this comment.
#if !defined(CONFIG_LIBRARY) && !defined(CONFIG_PM)
On MTL function platform_timer_stop does nothing from what I've seen.
Interrupts will be disabled later by the PM.
Collaborator
Author
There was a problem hiding this comment.
@tmleman may I ask why you are suggesting !defined(CONFIG_PM)? Did you mean defined(CONFIG_PM) instead? Would defined(CONFIG_CAVS) be a better option for TGL?
Contributor
There was a problem hiding this comment.
!defined(CONFIG_PM) and defined(CONFIG_CAVS) will have the same result. In my opinion, this code should not go to MTL. It will also probably not be needed once CAVS platforms start using the Zephyr power manager.
defined(CONFIG_CAVS) is fine for me too.
Contributor
Stop platform timer and disable interrupts before D3 entry for CAVS platforms. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
marked this pull request as ready for review
December 6, 2022 16:02
ranj063
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
December 6, 2022 16:02
tmleman
approved these changes
Dec 7, 2022
lgirdwood
approved these changes
Dec 7, 2022
9 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes the D3 sequence for IPC3 and IPC4 identical for TGL and fixes #6679 on TGL