[ujfalusi]

The MTL support added conditional build for topology2 based on CONFIG_CAVS or CONFIG_ACE.
This is wrong for several reasons:
There is not ace directory present
The Kconfig system is not used when building topologies, so we are ending up not building topology2 files at all.

There is no reason why CAVS and ACE topologies should be exclusive.

Fixes: 784bce7 ("mtl: Added meteorlake platform to the build system")
Signed-off-by: Peter Ujfalusi peter.ujfalusi@linux.intel.com

[marc-hb]

@softwarecki did you take some time off?

topology2 visible in
https://sof-ci.01.org/sofpr/PR6325/build1632/build/tools.txt

[plbossart]

I guess the topology2 issue was not found because we don't test the IPC4/topology2 configurations in the firmware PRs.

That's a big miss I am afraid. we probably need to move some daily test IPC4/topology2 devices to cover firmware and kernel PRs now. @keqiaozhang @lgirdwood @mengdonglin FYI

[keqiaozhang]

That's a big miss I am afraid. we probably need to move some daily test IPC4/topology2 devices to cover firmware and kernel PRs now

The reason why IPC4 was not added to the PR before is that the IPC4 test results were very bad at that time, but now it is much better. According to today's daily results, we have 3 critical issues left: FW# 6220 FW# 6203 and FW# 6213.

http://sof-ci.sh.intel.com/#/result/planresultdetail/15598

I think we can add TGLU_RVP_NOCODEC_IPC4ZPH to PR test first.

[plbossart]

That's a big miss I am afraid. we probably need to move some daily test IPC4/topology2 devices to cover firmware and kernel PRs now

The reason why IPC4 was not added to the PR before is that the IPC4 test results were very bad at that time, but now it is much better. According to today's daily results, we have 3 critical issues left: FW# 6220 FW# 6203 and FW# 6213.

http://sof-ci.sh.intel.com/#/result/planresultdetail/15598

I think we can add TGLU_RVP_NOCODEC_IPC4ZPH to PR test first.

That would be useful indeed (assuming we have no conflicts in resource usage)

I think we should include the basics of boot, checks on firmware and topology and what is known to work. The known issues can still be tracked in daily tests and the remaining test cases enabled in PRs when they are fixed.