Repository navigation
sof-logger: make inotify optional - #6191
Merged
Merged
Conversation
We moved to CMake and out-of-source builds years ago. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Restores ability to compile on Windows with MSYS. Fixes commit dcf0577 ("logger: allow starting before the driver is loaded") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
marked this pull request as ready for review
August 25, 2022 22:42
marc-hb
requested review from
aborisovich,
akloniex,
bkokoszx,
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 25, 2022 22:42
lgirdwood
approved these changes
Aug 26, 2022
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
LGTM, but lets wait for @aborisovich to review/test.
Collaborator
Author
|
2 suspend/resume timeouts and one unavailable device in https://sof-ci.01.org/sofpr/PR6191/build1310/devicetest/ . Nothing related. |
Contributor
|
@marc-hb @lgirdwood workaround works. Checked on windows with MSYS2, python3.10 and tgl target builds successfully. |
pjdobrowolski
approved these changes
Aug 29, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores ability to compile on Windows with MSYS.
Fixes commit dcf0577 ("logger: allow starting before the driver is
loaded")
Signed-off-by: Marc Herbert marc.herbert@intel.com