Repository navigation
Mixin: fix binding - #6138
Mixin: fix binding#6138
Conversation
The component .bind() method is called twice - for the upstream and for the downstream links. When mixout's .bind() is first called for the upstream link, it correctly sets up its connection to the mixin component. However, if after that .bind() is called for the downstream link, that configuration is overwritten with 0. Remove that overwrite. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
No need to check the same condition twice in a row, once is enough. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
|
@marcinszkudlinski @mwasko this fixes the problem, but I'm not sure whether this is really a correct fix |
serhiy-katsyuba-intel
left a comment
serhiy-katsyuba-intel
left a comment
There was a problem hiding this comment.
Great work, @lyakh!
Why are you not sure? This looks exactly like a proper fix :) |
@serhiy-katsyuba-intel I'm not sure because I don't quite understand why it was there initially and I don't know all possible scenarios when that path can be entered. So at least in theory this change, while fixing my case, can break something, that I'm not aware of. |
|
CI: two tests https://sof-ci.01.org/sofpr/PR6138/build1174/devicetest/?model=ADLP_RVP_NOCODEC_ZEPHYR&testcase=verify-tplg-binary and https://sof-ci.01.org/sofpr/PR6138/build1174/devicetest/?model=ADLP_RVP_NOCODEC_ZEPHYR&testcase=verify-pcm-list on ADLP_RVP_NOCODEC_ZEPHYR fail with timing out. An SSD problem? Additionally two suspend-resume tests timed out on APL_UP2_NOCODEC_ZEPHYR: https://sof-ci.01.org/sofpr/PR6138/build1174/devicetest/?model=APL_UP2_NOCODEC_ZEPHYR&testcase=check-suspend-resume-5 and https://sof-ci.01.org/sofpr/PR6138/build1174/devicetest/?model=APL_UP2_NOCODEC_ZEPHYR&testcase=check-suspend-resume-with-capture-5 |
looks like SSD issue ? @marc-hb any idea what this is doing other than wearing out the SSD ? I assume we want to flush VFS ? |
.bind() is called twice, in the order this is currently done in SOF, the second call overwrites with 0 the valid configuration from the first call. Remove that overwrite.