Repository navigation
dai-zephyr: add a DAI PRE_COPY trigger - #5963
Merged
lgirdwood merged 1 commit intoJul 11, 2022
Merged
Conversation
abonislawski
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
June 29, 2022 15:58
lgirdwood
reviewed
Jun 29, 2022
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Why is this needed and how does it differ from dai-legacy.c ?
Member
Author
|
@lgirdwood this is PR which introduced such approach to eliminate DMIC task: The problem was that it was added in legacy way to both dai-legacy and dai-zephyr so Jaska removed this from dai-zephyr and Im adding it again in zephyr native way. So the difference from dai-legacy is a call to zephyr dai rather than sof dai. There are also changes to Zephyr dai so Zephyr DMIC can use this: |
Add a DAI COPY trigger to be called before dma_copy Signed-off-by: Adrian Bonislawski <adrian.bonislawski@intel.com>
abonislawski
force-pushed
the
dai-zephyr_trigger_pre-copy
branch
from
July 7, 2022 10:23
da56e33 to
33e7dd0
Compare
Member
Author
|
@lgirdwood updated with comment and return check with warning |
lgirdwood
approved these changes
Jul 7, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is similar to 8f9b769
but using zephyr native dai method