[andrula-song]

Add local veriables to fix bug of ipc tx timed out for 0x60060000
(TRIG_PAUSE) when testing multiple-pause-resume on ADLP Chrome device.

Signed-off-by: Andrula Song xiaoyuan.song@intel.com

[andrula-song]

compared with the function comp_get_copy_limits_with_lock,
` struct comp_buffer __sparse_cache *source_c, *sink_c;

source_c = buffer_acquire(source);
sink_c = buffer_acquire(sink);

comp_get_copy_limits(source_c, sink_c, cl);

buffer_release(source_c);
buffer_release(sink_c);`

maybe the root cause is the usage of local __sparse_cache variables.

[ranj063]

@andrula-song whats the rationale for using a local variable? I understand it fixes the bug but how do we explain it?

[lgirdwood]

The bug is being fixed here as the ordering of the locking and unlocking is now symmetrical.

[andrula-song]

@lgirdwood But the ordering of the locking and unlocking in function comp_get_copy_limits_with_lock is unsymmetrical too (And that will not lead to the bug).
Firstly I wanna test without transfer the order, but there would be failed issues of case check-suspend-resume-with-playback-5.sh and check-suspend-resume-with-capture-5.sh on WHL_UPEXT_HDA_ZEPHYR. After transfer the order of the locking and unlocking, these two failure are still exist. But both are not IPC time out.
@lyakh Can you help to introduce why we should use '__sparse_cache'?

[lgirdwood]

@lgirdwood But the ordering of the locking and unlocking in function comp_get_copy_limits_with_lock is unsymmetrical too (And that will not lead to the bug).

This need fixed too. Pls send a PR. Thanks.

[andrula-song]

@ranj063 I am not sure would this will fix the bug, but maybe @lyakh can help to explain why we should use comp_buffer with __sparse_cache.

[keqiaozhang]

Confirmed that this PR can fix #5850.

[lgirdwood]

The bug is being fixed here as the ordering of the locking and unlocking is now symmetrical.

[marc-hb]

but maybe @lyakh can help to explain why we should use comp_buffer with __sparse_cache.

So the local variables were required because __sparse_cache was required, correct?

In other words, the author of the fix does not fully understand the fix yet... very scary.