Build mt8195 mt8186 into SOF docker image by tinghan-shen · Pull Request #5388 · thesofproject/sof

tinghan-shen · 2022-02-18T03:44:23Z

test test

Signed-off-by: Tinghan Shen tinghan.shen@mediatek.com

tinghan-shen · 2022-02-18T05:34:30Z

The CI build for mt8195 and mt8186 is still failed with this PR.
https://github.com/thesofproject/sof/runs/5243341615?check_suite_focus=true

marc-hb · 2022-02-18T06:17:13Z

The CI build for mt8195 and mt8186 is still failed with this PR.

I don't understand. First this PR needs to be merged, then someone needs to rebuild and publish a new Docker image. Only then can the toolchain be used in other PRs. The Docker update process is all manual for now, see discussion in #5073 We don't update the docker image very often so it has not been worth the effort to fully automate its creation and test.

Did you build a new docker image on your system with this change? Then did you test it that docker image, I mean did you try to build SOF with it?

tinghan-shen · 2022-02-18T06:37:58Z

Oh, I get your point. I had a miss understanding of the process when I test the CI by this PR.
I was a bit worry about the issue of gcc-build-only for mt8186 and mt8195.
I was thought that this has to be solved ASAP.

I guess I can close this PR and wait until the Docker image updated.
I will take some time to build the docker image locally.
thank you, marc.

afq984 · 2022-05-12T17:34:38Z

Hi @marc-hb I wonder what is missing for a docker image that supports targeting mt81xx?
The work for xtensa-overlay and crosstool-ng seems complete [1][2].

[1] thesofproject/xtensa-overlay@ccd9727
[2] thesofproject/crosstool-ng@3d5c8ed

marc-hb · 2022-05-12T19:37:01Z

@fredoh9 can you try this?

marc-hb · 2022-05-13T18:36:38Z

I will take some time to build the docker image locally.

Just trying to make sure there is no misunderstanding: @afq984 you did test this PR on your personal system, correct? I mean you created a Docker image with the mt818x toolchains and tested them and they worked fine?

Manual and local testing is required because we have no automated testing for Docker changes (#5073).

I'm asking because ~~you~~ @tinghan-shen closed this PR on Feb 17 after writing this, I wonder why. Also, it was always a draft, never promoted.

afq984 · 2022-05-13T18:49:56Z

you did test this PR on your personal system, correct?

no, I ran into some weird ulimit issues to build the image that I hadn't figure out

I'm asking because you closed this PR on Feb 17

It was @tinghan-shen, not me :)

marc-hb · 2022-05-13T19:11:54Z

Some ulimit defaults are often too small for crosstool-ng

https://github.com/crosstool-ng/crosstool-ng/issues?q=ulimit

Just trying increasing the failing ones temporarily in the terminal before cleaning and trying to build again

tinghan-shen · 2022-05-16T08:34:40Z

I will take some time to build the docker image locally.

I'm asking because ~~you~~ @tinghan-shen closed this PR on Feb 17 after writing this, I wonder why. Also, it was always a draft, never promoted.

I'm sorry. I haven't done it since then. I'll find some time to do it.
This PR was created to test the CI for mt8195 and mt8186, so I didn't plan to promote this PR.

marc-hb · 2022-05-16T14:13:51Z

I'll find some time to do it.

Thank you!

This PR was created to test the CI for mt8195 and mt8186, so I didn't plan to promote this PR.

But this PR can still:

be used for testing on your local workstation?
be submitted and merged once your local testing is successful?
be kept open as a draft to show that you're still trying to find time to work on it?

It's your PR so you can do what you want, just some suggestions :-)

marc-hb · 2022-05-18T04:17:46Z

@tinghan-shen I wonder what you're expecting with your recent, "debug" pushes... did you misunderstand or forget this below?

someone needs to rebuild and publish a new Docker image. Only then can the toolchain be used in other PRs. The Docker update process is all manual for now, see discussion in #5073 We don't update the docker image very often so it has not been worth the effort to fully automate its creation and test.

Changes to scripts/docker_build/sof_builder/Dockerfile are NOT tested in any CI, every CI uses the static Docker image that was manually built, tested and uploaded.

marc-hb · 2022-05-18T04:04:39Z

The set -x should print the command below which contains $SOF_DOCKER_RUN

This is a hack and dropped now.

marc-hb · 2022-05-18T04:04:42Z

Our documentation used to recommend creating such a local sof tag but I removed it after wasting too much time forgetting to update it.

This is a hack and dropped now.

tinghan-shen · 2022-05-18T05:34:08Z

@tinghan-shen I wonder what you're expecting with your recent, "debug" pushes... did you misunderstand or forget this below?

someone needs to rebuild and publish a new Docker image. Only then can the toolchain be used in other PRs. The Docker update process is all manual for now, see discussion in #5073 We don't update the docker image very often so it has not been worth the effort to fully automate its creation and test.

Changes to scripts/docker_build/sof_builder/Dockerfile are NOT tested in any CI, every CI uses the static Docker image that was manually built, tested and uploaded.

Hi Marc,

I had a local build SOF docker image and still under testing.
I forget to do it in another local branch, but update to this PR branch directly.
Sorry for causing any inconvenience.

tinghan-shen · 2022-05-19T01:52:47Z

@marc-hb, my local built SOF docker image can build mt8186 and mt8195 image after applied the docker_build commit in this PR.

Will intel update the image on dockerhub? or I can update it?

marc-hb

Great news, thanks! Let's merge this and yes someone at Intel will update the Docker image (I can't promise when exactly)

afq984 · 2022-05-19T03:22:45Z

thanks for doing this :)

tinghan-shen · 2022-05-19T05:32:04Z

Great news, thanks! Let's merge this and yes someone at Intel will update the Docker image (I can't promise when exactly)

Should I remove the change for .github before the Docker image updated?

marc-hb · 2022-05-19T18:21:20Z

Should I remove the change for .github before the Docker image updated?

Yes please. It requires an updated Docker image.

You can comment it out and leave a TODO.

.github/ too soon.

Add support for building mt8186 and mt8195 toolchain in docker image. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>

Add masked mt81xx gcc build to pull request tests. Unmask mt81xx after docker image updated with mt81xx toolchain. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>

tinghan-shen · 2022-05-20T01:35:16Z

Yes please. It requires an updated Docker image.

You can comment it out and leave a TODO.

Updated. Thanks!

marc-hb

ICL-only Copy build to DUT FAIL in https://sof-ci.01.org/sof-pr-viewer/#/build/PR5388/build9383529, @wszypelt any idea?

Unfortunately common suspend/resume failures in https://sof-ci.01.org/sofpr/PR5388/build430/devicetest, unrelated.

lgirdwood · 2022-05-24T15:44:13Z

SOFCI TEST

marc-hb · 2022-05-24T15:59:08Z

SOFCI TEST

scripts/docker_build/sof_builder/Dockerfile is not tested in CI, see discussion above.

marc-hb · 2022-06-01T19:05:13Z

Added to Github Actions in

[SKIP CI] github: add mt8186 and mt8195 #5882

Thank you @fredoh9 for the Docker update.

tinghan-shen requested review from dbaluta, lbetlej, lgirdwood, mmaka1 and plbossart as code owners February 18, 2022 03:44

tinghan-shen closed this Feb 18, 2022

tinghan-shen removed request for dbaluta, lbetlej, lgirdwood, mmaka1 and plbossart February 18, 2022 03:45

tinghan-shen reopened this Feb 18, 2022

tinghan-shen requested review from cujomalainey, marc-hb and zrombel as code owners February 18, 2022 03:50

tinghan-shen removed request for cujomalainey, marc-hb and zrombel February 18, 2022 03:51

tinghan-shen marked this pull request as draft February 18, 2022 03:52

tinghan-shen closed this Feb 18, 2022

tinghan-shen mentioned this pull request Feb 18, 2022

[SKIP CI] .github: add mt8186 and mt8195 to "build-only" #5386

Closed

marc-hb requested review from fredoh9, greg-intel and juimonen February 18, 2022 05:13

tinghan-shen reopened this Feb 18, 2022

tinghan-shen closed this Feb 18, 2022

marc-hb reopened this May 12, 2022

marc-hb mentioned this pull request May 12, 2022

drivers: mediatek: fix build error #5808

Merged

marc-hb reviewed May 18, 2022

View reviewed changes

tinghan-shen changed the title ~~test mt8195 mt8186 CI~~ Build mt8195 mt8186 into SOF docker image May 19, 2022

tinghan-shen marked this pull request as ready for review May 19, 2022 01:59

tinghan-shen requested a review from aborisovich as a code owner May 19, 2022 01:59

marc-hb previously approved these changes May 19, 2022

View reviewed changes

marc-hb mentioned this pull request May 19, 2022

Enabling SOF Support For AMD Rembrandt platform #5833

Merged

tinghan-shen added 2 commits May 20, 2022 09:29

docker_build: Add support for mt8195 and mt8186

9e9d53e

Add support for building mt8186 and mt8195 toolchain in docker image. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>

.github: Add a TODO for mt81xx gcc build to pull request tests

91bbb57

Add masked mt81xx gcc build to pull request tests. Unmask mt81xx after docker image updated with mt81xx toolchain. Signed-off-by: Tinghan Shen <tinghan.shen@mediatek.com>

marc-hb approved these changes May 20, 2022

View reviewed changes

lgirdwood approved these changes May 24, 2022

View reviewed changes

lgirdwood merged commit 41992a2 into thesofproject:main May 25, 2022

Conversation

tinghan-shen commented Feb 18, 2022

Uh oh!

tinghan-shen commented Feb 18, 2022

Uh oh!

marc-hb commented Feb 18, 2022

Uh oh!

tinghan-shen commented Feb 18, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

afq984 commented May 12, 2022

Uh oh!

marc-hb commented May 12, 2022

Uh oh!

marc-hb commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

afq984 commented May 13, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc-hb commented May 13, 2022

Uh oh!

tinghan-shen commented May 16, 2022

Uh oh!

marc-hb commented May 16, 2022

Uh oh!

marc-hb commented May 18, 2022

Uh oh!

marc-hb May 18, 2022

Choose a reason for hiding this comment

Uh oh!

tinghan-shen May 19, 2022

Choose a reason for hiding this comment

Uh oh!

marc-hb May 18, 2022

Choose a reason for hiding this comment

Uh oh!

tinghan-shen May 19, 2022

Choose a reason for hiding this comment

Uh oh!

tinghan-shen commented May 18, 2022

Uh oh!

tinghan-shen commented May 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

afq984 commented May 19, 2022

Uh oh!

tinghan-shen commented May 19, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

marc-hb commented May 19, 2022

Uh oh!

tinghan-shen commented May 20, 2022

Uh oh!

marc-hb left a comment

Choose a reason for hiding this comment

Uh oh!

lgirdwood commented May 24, 2022

Uh oh!

marc-hb commented May 24, 2022

Uh oh!

marc-hb commented Jun 1, 2022 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

tinghan-shen commented Feb 18, 2022 •

edited

Loading

marc-hb commented May 13, 2022 •

edited

Loading

afq984 commented May 13, 2022 •

edited

Loading

tinghan-shen commented May 19, 2022 •

edited

Loading

tinghan-shen commented May 19, 2022 •

edited

Loading

marc-hb commented Jun 1, 2022 •

edited

Loading