Repository navigation
zephyr: add support to build SOF with IPC4 and zephyr - #5344
Merged
Merged
Conversation
The two components copier and base_fw are essential to IPC4 support on SOF on Zephyr. This patch integrates the build of the two components to SOF build with zephyr RTOS. Signed-off-by: Chao Song <chao.song@linux.intel.com>
aiChaoSONG
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
February 11, 2022 02:00
aiChaoSONG
changed the title
aiChaoSONG
marked this pull request as draft
February 11, 2022 05:11
The copier component depends on special pcm conversion
code, which is only implemented in the generic pcm
converter. If we build SOF with IPC4 support with XCC,
the HIFI3 pcm converter is selected automatically, and
causes the issue of
undefined reference to `pcm_func_vc_count'
undefined reference to `pcm_func_vc_map'.
This patch forces the use of generic pcm converter
if build SOF with IPC4 and Zephyr.
This patch should be reverted once the HIFI3 pcm converter
counterpart is implemented.
Signed-off-by: Chao Song <chao.song@linux.intel.com>
aiChaoSONG
force-pushed
the
zephyr_ipc4
branch
from
February 11, 2022 05:18
9b936a6 to
e9f66c5
Compare
aiChaoSONG
marked this pull request as ready for review
February 11, 2022 05:19
lgirdwood
approved these changes
Feb 11, 2022
|
|
||
| #ifndef UNIT_TEST | ||
| #if __XCC__ && XCHAL_HAVE_HIFI3 && CONFIG_FORMAT_CONVERT_HIFI3 | ||
| #if __ZEPHYR__ && CONFIG_IPC_MAJOR_4 |
Member
There was a problem hiding this comment.
@singalsu @andrula-song fyi - can someone check what's needed here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two commits: