Repository navigation
Fix incremental builds of topology2 that were missing ALSA_CONFIG_DIR. - #5255
Merged
Merged
Conversation
alsatplg accepts empty definitions -D "" so let's simplify commit cb80023 ("topology2: fix build issues with no command line definitions"); 10 lines shorter. The less CMake code the better. Zero change, the build directory is bit for bit identical after this commit. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Fixes incremental builds of topology2 that were missing ALSA_CONFIG_DIR. This was making it impossible to troubleshoot alsatplg issues like thesofproject#5249. Now incremental builds fail or pass the same as builds from scratch. Fixes commit 308a24a ("topology2: Add build support") Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
requested review from
aiChaoSONG,
bardliao,
greg-intel,
lgirdwood,
lkoenig,
ranj063 and
yongzhi1
January 25, 2022 02:36
Collaborator
Author
|
Lucky me everything passed in https://sof-ci.01.org/sofpr/PR5255/build11770/devicetest/ except unrelated thesofproject/linux/issues/3370 |
ranj063
approved these changes
Jan 25, 2022
lgirdwood
approved these changes
Jan 25, 2022
Collaborator
Author
|
I left this as draft by mistake sorry. |
marc-hb
marked this pull request as ready for review
January 26, 2022 18:13
marc-hb
requested review from
dbaluta,
lbetlej,
mmaka1 and
plbossart
as code owners
January 26, 2022 18:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
3 commits, please review individually.
Follow-up to #5249 and before.