Skip to content

test: topology: fix build with latest alsa-lib - #5156

Merged
ranj063 merged 1 commit into
thesofproject:mainfrom
ranj063:fix/test_topology
Jan 6, 2022
Merged

ranj063 merged 1 commit into
thesofproject:mainfrom
ranj063:fix/test_topology

Conversation

@ranj063

@ranj063 ranj063 commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

Remove the extra space to make the topology build with upstream
alsa-lib.

Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com

Remove the extra space to make the topology build with upstream
alsa-lib.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@greg-intel

greg-intel commented Jan 6, 2022 •

Copy link
Copy Markdown
Contributor

Should I circle back tomorrow, switch the latest tag to point at the image we built today, and rerun the tests, to see if the new image is compatible? (Some of the CI is still running, and I've been running since 6AM, myself)

@marc-hb

marc-hb commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

off-topic sorry but I don't expect any intense discussion about this whitespace to happened and be polluted by this: what would it take to address the millions of ALSA lib pcm.c:1471:(tplg_parse_hw_config) deprecated bclk value 'codec_slave', use 'codec_consumer'? A huge search/replace? They made finding error messages in #5155 really difficult.

@marc-hb

marc-hb commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

Should I circle back tomorrow, switch the latest tag to point at the image we built today, and rerun the tests, to see if the new image is compatible?

After this is merged yes.

@greg-intel

Copy link
Copy Markdown
Contributor

Re-ran the testbench tests against the new image and they passed. These were the tests that failed in PR 5155

@ranj063
ranj063 merged commit fcfd5d6 into thesofproject:main Jan 6, 2022
@ranj063
ranj063 deleted the fix/test_topology branch January 6, 2022 18:35
@marc-hb

marc-hb commented Jan 6, 2022

Copy link
Copy Markdown
Collaborator

Answering myself

what would it take to address the millions of ALSA lib pcm.c:1471:(tplg_parse_hw_config) deprecated bclk value 'codec_slave', use 'codec_consumer'? A huge search/replace?

Yes. Submitted in #5162.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants