Skip to content

platform: cavs: make IMR restore feature default - except APL - #5109

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
plbossart:fix/enable-imr-d3-persistent
Jan 11, 2022
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
plbossart:fix/enable-imr-d3-persistent

Conversation

@plbossart

Copy link
Copy Markdown
Member

Let's enable this capability, with ApolloLake left out for now since there
are known issues with suspend-resume on Up2 board that were never
root-caused.

Enabling this at the firmware level is not enough, this capability
need to be enabled by kernel patches in
thesofproject/linux#3340

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

@plbossart

Copy link
Copy Markdown
Member Author

PR created for the sole purpose of joint testing with the matching kernel PR thesofproject/linux#3340

NO MERGE until the test results are known.

@marc-hb

marc-hb commented Dec 17, 2021

Copy link
Copy Markdown
Collaborator

SOFCI TEST

@marc-hb

marc-hb commented Dec 18, 2021

Copy link
Copy Markdown
Collaborator

Everything including https://sof-ci.01.org/sofpr/PR5109/build11411/devicetest is green.

@keyonjie

keyonjie commented Dec 20, 2021 •

Copy link
Copy Markdown
Contributor

@plbossart not sure if the kconfig change is correct, but I am not seeing dmesg log "IMR restore supported, booting from IMR directly" in https://sof-ci.01.org/sofpr/PR5109/build11411/devicetest

@keqiaozhang FYI.

@lgirdwood

Copy link
Copy Markdown
Member

@plbossart not sure if the kconfig change is correct, but I am not seeing dmesg log "IMR restore supported, booting from IMR directly" in https://sof-ci.01.org/sofpr/PR5109/build11411/devicetest

@keqiaozhang FYI.

LGTM unless you mean we need to say CAVS_15 in the Kconfig instead of APOLLO_LAKE ?

Let's enable this capability, with CAVS_1_5 left out for now since there
are known issues with suspend-resume on Up2 board that were never
root-caused.

Enabling this at the firmware level is not enough, this capability
need to be enabled by kernel patches in
thesofproject/linux#3340

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
plbossart force-pushed the fix/enable-imr-d3-persistent branch from af5bb6b to 82ad6cd Compare January 10, 2022 19:08
@plbossart
plbossart marked this pull request as ready for review January 10, 2022 19:08
@plbossart

Copy link
Copy Markdown
Member Author

LGTM unless you mean we need to say CAVS_15 in the Kconfig instead of APOLLO_LAKE ?

Right, I used CAVS_VERSION_1_5 in the update.

@lgirdwood
lgirdwood merged commit 71cd966 into thesofproject:main Jan 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants