Repository navigation
Revert pipeline stop changes - #4920
Conversation
This reverts commit b5506ed. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
This reverts commit b6f26b0. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
This reverts commit 0fe263d. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
This reverts commit 756f47a. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
|
hi @ranj063 , thanks for your quick response . Ran some basic aplay arecord test , the result is PASS .[see inner test 7699 7698] |
|
Bisect shows that the DSP panic issue is caused by: Checked this commit with yesterday kernel sof-dev/ 3f5049f6eed8, issue is still reproducible. So this issue has nothing to do with kernel. |
|
We should rebuild the SOF for daily test after this PR gets merged today, otherwises the kernel PR test will always fail. Should we revert all 4 relevant commits or just remove the rootcause one ? |
@aiChaoSONG that commit alone cannot be cleanly reverted. So I reverted all |
Looking at the original #4724 there are 1 functional change + 3 "cosmetic" commits. The 3 "cosmetic" commits are after the functional change = hence the revert conflicts |
|
The root cause is that there’re some relations between PR #4724 and PR #4885. The PR test for #4724 was based on sof commit 1ef769d, at that time #4885 had not been merged,which make sense that the PR test passed. Then #4724 merged before #4885 and issue happened. |
|
Is everyone good with the revert? can some one with merge right merge this, or all of our test will fail. |
Doing that now. |
No description provided.