Repository navigation
Conversation
If the last task completes in a domain, don't re-enable it. It will be re-enabled when a new task is submitted. Signed-off-by: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
ranj063
reviewed
Oct 13, 2021
|
|
||
| /* tasks on current core finished, re-enable domain on it */ | ||
| domain_enable(domain, core); | ||
| if (atomic_read(&sch->num_tasks)) |
Collaborator
There was a problem hiding this comment.
the comment above doesnt match the change?
Contributor
|
Looks good to me, thanks. |
Collaborator
Author
|
sorry, I should've explained - this is a draft PR because it's just a "bisect" of #4856 where 3 patches cause a single QB failure. This is one of those 3 commits, that I think is the most likely culprit, although I still don't see why it would be wrong. So, this PR is testing-only, not for review. |
Collaborator
Author
|
SOFCI TEST |
lyakh
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the last task completes in a domain, don't re-enable it. It will be re-enabled when a new task is submitted.