Repository navigation
Make cpu power down IDC blocking - #4628
Merged
Merged
Conversation
ranj063
requested review from
dbaluta,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 12, 2021 00:38
ranj063
changed the title
Collaborator
Author
|
@lgirdwood this change fixes the IDC timeout issue with repeated core power up/down but I'm not convinced this is entirely right. |
ranj063
changed the title
ranj063
force-pushed
the
fix/core_power_down
branch
from
August 12, 2021 03:44
c9b742f to
2d34e90
Compare
make the core power down IDC blocking to ensure the core is actually idle before notifying the host. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
ranj063
force-pushed
the
fix/core_power_down
branch
from
August 12, 2021 04:21
2d34e90 to
a11d752
Compare
ranj063
changed the title
Collaborator
Author
@lgirdwood after a bit more testing, I realized that simply making sure to block until the power down IDC actually idles the core fixes the issue for me |
abonislawski
approved these changes
Aug 12, 2021
lgirdwood
approved these changes
Aug 12, 2021
Member
|
CI showing Zephyr, known and unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make sure to clock the power down IDC block until the core is idled
Fixes #4602