Repository navigation
ssp and idc minor updates. - #4608
Merged
Merged
Conversation
Let the users know what message has timed out on other cores. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
Git comments indicate the delay is for consumer mode only. Lets not delay in SSP clock producer mode. Signed-off-by: Liam Girdwood <liam.r.girdwood@linux.intel.com>
lgirdwood
requested review from
dbaluta,
lbetlej,
mmaka1 and
plbossart
as code owners
August 6, 2021 10:29
This was referenced Aug 6, 2021
lyakh
approved these changes
Aug 6, 2021
ranj063
reviewed
Aug 6, 2021
| case SOF_DAI_FMT_CBC_CFC: | ||
| break; | ||
| default: | ||
| /* delay for all SSP consumed clocks atm - see above */ |
Collaborator
There was a problem hiding this comment.
only minor . typo consumed -> consumer
Member
There was a problem hiding this comment.
good change @lgirdwood we should add this patch as a separate PR, it might help even outside of multi-core changes.
Contributor
There was a problem hiding this comment.
What is the motivation of the change here? the PLATFORM_SSP_DELAY delay is only some us, no?
Member
Author
There was a problem hiding this comment.
The delay is NOT needed in SSP clock producer mode. It can be 100uS.
ranj063
approved these changes
Aug 6, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tell users which IDC is failing and only delay in SSP clock consumer modes.