Skip to content

topology: sof-glk-es8336: initial support - #4577

Merged
lgirdwood merged 2 commits into
thesofproject:mainfrom
plbossart:topology/add-sof-glk-es8336
Sep 8, 2021
Merged

topology: sof-glk-es8336: initial support#4577
lgirdwood merged 2 commits into
thesofproject:mainfrom
plbossart:topology/add-sof-glk-es8336

Conversation

@plbossart

@plbossart plbossart commented Jul 30, 2021

Copy link
Copy Markdown
Member

Added from internal example

Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com

@plbossart
plbossart force-pushed the topology/add-sof-glk-es8336 branch from 64af534 to 94c136f Compare August 2, 2021 19:21
@plbossart

plbossart commented Aug 4, 2021

Copy link
Copy Markdown
Member Author

@hli25 can you try the TGL topology update? thanks!

@hli25

hli25 commented Aug 7, 2021

Copy link
Copy Markdown

@hli25 can you try the TGL topology update? thanks!
yes, this TGL topology works too.
BTW, on TGL there is PCH-attached dmics.

@plbossart

plbossart commented Aug 9, 2021

Copy link
Copy Markdown
Member Author

@hli25 can you try the TGL topology update? thanks!
yes, this TGL topology works too.
BTW, on TGL there is PCH-attached dmics.

@hli25 please try the DMIC update, that should be similar to what you tested?

@hli25

hli25 commented Aug 10, 2021

Copy link
Copy Markdown

@hli25 can you try the TGL topology update? thanks!
yes, this TGL topology works too.
BTW, on TGL there is PCH-attached dmics.

@hli25 please try the DMIC update, that should be similar to what you tested?
Yes, DMIC works too on my TGL device with this topology.
btw, my GLK device work fine as before with this update.

@plbossart

plbossart commented Aug 10, 2021

Copy link
Copy Markdown
Member Author

@hli25 can you try the TGL topology update? thanks!
yes, this TGL topology works too.
BTW, on TGL there is PCH-attached dmics.

@hli25 please try the DMIC update, that should be similar to what you tested?
Yes, DMIC works too on my TGL device with this topology.
btw, my GLK device work fine as before with this update.

great so now the only thing missing is HDMI/DP support. Do your devices have such connectors?

@hli25

hli25 commented Aug 12, 2021 •
edited
Loading

Copy link
Copy Markdown

@hli25 can you try the TGL topology update? thanks!
yes, this TGL topology works too.
BTW, on TGL there is PCH-attached dmics.

@hli25 please try the DMIC update, that should be similar to what you tested?
Yes, DMIC works too on my TGL device with this topology.
btw, my GLK device work fine as before with this update.

great so now the only thing missing is HDMI/DP support. Do your devices have such connectors?

@plbossart
The 2 devices in my hand has type-c port, so i can connect HDMI/DP monitor to them. Now a draft kernel patch was uploaded, most of the codes were borrowed from other existing machine drivers. But unfortunately, HDMI/DP has no sound output. HDMI/DP support -- draft patch, and logs. Please give some suggestion, thanks.

BTW, here is topology file update, without them there is no HDMI/DP device in the output of "aplay -l":

@plbossart
plbossart force-pushed the topology/add-sof-glk-es8336 branch from 66daed3 to 8ced470 Compare August 19, 2021 14:09
@plbossart
plbossart marked this pull request as ready for review August 19, 2021 14:09
@plbossart
plbossart requested a review from lgirdwood August 19, 2021 14:09
@plbossart plbossart mentioned this pull request Aug 19, 2021
Merged
@plbossart

plbossart commented Aug 19, 2021 •
edited
Loading

Copy link
Copy Markdown
Member Author

This PR is now ready for review thanks to the work of @hli25

Dependencies:
SOF driver update in thesofproject/linux#2962
codec driver update in #3107 - this needs to be cleaned up by codec vendor and is not something the SOF team should review.

@plbossart
plbossart requested review from bardliao and ranj063 August 19, 2021 14:13
kv2019i
kv2019i requested changes Aug 20, 2021
View reviewed changes

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

M4 quoting issue in HDMI definition.

Comment thread tools/topology/topology1/sof-glk-es8336.m4 Resolved
@plbossart
plbossart force-pushed the topology/add-sof-glk-es8336 branch from 8ced470 to 17549a5 Compare August 20, 2021 17:31
@plbossart

plbossart commented Aug 20, 2021

Copy link
Copy Markdown
Member Author

@hli25 please retest with HDMI no longer optional to make the m4 less complicated

@plbossart
plbossart requested a review from kv2019i August 20, 2021 17:32
@hli25

hli25 commented Aug 23, 2021

Copy link
Copy Markdown

@hli25 please retest with HDMI no longer optional to make the m4 less complicated

HDMI/DP playback works with this topology, verified on my device.

@lgirdwood

lgirdwood commented Aug 24, 2021

Copy link
Copy Markdown
Member

SOFCI TEST

@lgirdwood lgirdwood added this to the v1.9 milestone Sep 7, 2021
@lgirdwood

lgirdwood commented Sep 7, 2021

Copy link
Copy Markdown
Member

@plbossart probably good to merge for v1.9 ? Just a conflict to sort..

@plbossart
topology: sof-glk-es8336: initial support
3779dc4 
This topology is used on GLK and TGL. variations include:
- DMIC supported on TGL and not on GLK
- TGL uses SSP0 instead of SSP2

APL support was added only based on user reports. This assumes the
same topology as GLK but was not tested.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
topology: move IMX and MTK topologies out of Intel list
a26f282 
Not sure why they were intertwined, let's separate them out to avoid
git conflicts with integration.

Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
@plbossart
plbossart force-pushed the topology/add-sof-glk-es8336 branch from 17549a5 to a26f282 Compare September 7, 2021 16:02
@plbossart

plbossart commented Sep 7, 2021

Copy link
Copy Markdown
Member Author

@plbossart probably good to merge for v1.9 ? Just a conflict to sort..

@lgirdwood fixed conflict and fixed source of conflict: no reason why IMX/MTK topologies should be in the middle of Intel ones.

@lgirdwood
lgirdwood merged commit 8fc5247 into thesofproject:main Sep 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kv2019i kv2019i kv2019i approved these changes
@dbaluta dbaluta Awaiting requested review from dbaluta
@lbetlej lbetlej Awaiting requested review from lbetlej
@mmaka1 mmaka1 Awaiting requested review from mmaka1
@lgirdwood lgirdwood Awaiting requested review from lgirdwood
@ranj063 ranj063 Awaiting requested review from ranj063 ranj063 is a code owner
@bardliao bardliao Awaiting requested review from bardliao

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

v1.9

Development

Successfully merging this pull request may close these issues.

4 participants

@plbossart @hli25 @lgirdwood @kv2019i