Skip to content

Tools: Fix topology1 path in Matlab language scripts - #4515

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
singalsu:matlab_fixes_for_topology1
Jul 21, 2021
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
singalsu:matlab_fixes_for_topology1

Conversation

@singalsu

Copy link
Copy Markdown
Collaborator

The change for topology1 was missing from various tuning
and testing scripts those access binary blob data from
topology m4 directories.

Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com

The change for topology1 was missing from various tuning
and testing scripts those access binary blob data from
topology m4 directories.

Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
@singalsu
singalsu requested a review from johnylin76 July 20, 2021 15:06
@singalsu
singalsu marked this pull request as ready for review July 20, 2021 15:09

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu these file should really be passed into the the matlab scripts as topology2 version will also need parsed ? You could default to topology1 (and print this out in teh script so that users no).
i.e. "no topology file specified using -t option, using topology.m4 as default"

@singalsu

singalsu commented Jul 21, 2021 •

Copy link
Copy Markdown
Collaborator Author

@lgirdwood At the moment there's only in topology1 support and this PR just restores functionality of e.g. processing component tests with testbench and restores functionality of the blobs generators. I need to figure out later how to support topology2 with all the tools and tests. I assume the binary (hex) blobs format will change since it's currently m4 syntax.

@lgirdwood
lgirdwood merged commit 4c37668 into thesofproject:main Jul 21, 2021
@lgirdwood

Copy link
Copy Markdown
Member

@singalsu ok, please create a v1.9 issue for it, we need to make sure matlab can use bot topology 1 and 2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants