Skip to content

Revert "pipeline/buffer: alloc them in the runtime shared zone" - #4439

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
ranj063:fix/buffer_alloc
Jul 1, 2021
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
ranj063:fix/buffer_alloc

Conversation

@ranj063

@ranj063 ranj063 commented Jul 1, 2021

Copy link
Copy Markdown
Collaborator

Revert these for now. Will be fixed with other multi-core fixes.

This reverts commit 928dba0.

Signed-off-by: Ranjani Sridharan ranjani.sridharan@linux.intel.com

Revert these for now. Will be fixed with other multi-core fixes.

This reverts commit 928dba0.

Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
@keyonjie

keyonjie commented Jul 1, 2021

Copy link
Copy Markdown
Contributor

@lgirdwood since the cAVS memory map refinement may take some time, so better to revert this now to rescue the CI first.

@lgirdwood
lgirdwood merged commit e1b1fed into thesofproject:main Jul 1, 2021
@lgirdwood

Copy link
Copy Markdown
Member

@ranj063 can you create a ranj/topic/multicore branch on the sof repo for the multicore development. This branch will be the optimisation branch that can be merged in agian after @keyonjie has fixed the heap mappings.
@keyonjie can you explain why the heap refinement will take some time ? The heap dump is showing that we have lost of free space in certain blocks athat can be moved to other heaps or block ?

@keyonjie

keyonjie commented Jul 2, 2021 •

Copy link
Copy Markdown
Contributor

@ranj063 can you create a ranj/topic/multicore branch on the sof repo for the multicore development. This branch will be the optimisation branch that can be merged in agian after @keyonjie has fixed the heap mappings.
@keyonjie can you explain why the heap refinement will take some time ? The heap dump is showing that we have lost of free space in certain blocks athat can be moved to other heaps or block ?

Hi @lgirdwood I wanted to combine and reduce the type numbers of the mm_heap, e.g. only system, runtime, shared are needed, no system_runtime, buffer, system shared needed, that's why I said it will take some time.

But since that could be relative invasive change may impact IMX paltforms also, let me do smaller change to just make full use of our SRAM heap blocks only, this could be more easier and hopefully it will come within one or two days.

@keyonjie

keyonjie commented Jul 2, 2021

Copy link
Copy Markdown
Contributor

@ranj063 @lgirdwood now refinement available, we have much more memory to use on TGL/CNL/ICL platforms now.

#4445
thesofproject/rimage#51

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants