Repository navigation
codec_adapter: cadence: Reset init_done at init time - #4394
Merged
Merged
Conversation
After first compress play run init_done is initialized with 1 and it keeps this value as no one resets it. This causes subsequent compress play to miss codec process init phase and this causes decoding to fail. With this change multiple cplay runs work fine! Notice that cadence_codec_reset calls cadence_codec_init and thus resets init_done flag. Signed-off-by: Daniel Baluta <daniel.baluta@nxp.com>
dbaluta
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
June 23, 2021 15:38
dbaluta
requested review from
ViorelSuman,
harshapriya-n,
iuliana-prodan,
mrajwa and
paulstelian97
June 23, 2021 15:38
iuliana-prodan
approved these changes
Jun 23, 2021
plbossart
approved these changes
Jun 23, 2021
mrajwa
approved these changes
Jun 23, 2021
Contributor
Collaborator
Author
Contributor
|
is the cadence_codec_reset() symmetric with cadence_codec_init() here? can we reset the init_done in _reset()? |
Collaborator
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After first compress play run init_done is initialized with 1 and it
keeps this value as no one resets it.
This causes subsequent compress play to miss codec process init phase
and this causes decoding to fail.
With this change multiple cplay runs work fine!
Notice that cadence_codec_reset calls cadence_codec_init and thus resets
init_done flag.
Signed-off-by: Daniel Baluta daniel.baluta@nxp.com