Repository navigation
Prepare for building Topology2.0 topologies - #4363
Conversation
55037b7 to
09c0bdc
Compare
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
I guess the build scripts wont need updated as changes will be incorporated in the makefiles ?
There was a problem hiding this comment.
We probably need a Readme.md in the topology1 directory stating that the M4 topology is being deprecated. This can be an incremental PR.
ce2929b to
0c07a25
Compare
|
@ranj063 I've finished merging for tonight - good time to fix the conflicts now :) |
@lgirdwood, i've fixed the conflicts now but there are a bunch of topology PR's pending. Should we merge those before merging this? |
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Main issue is the "fake?" final_output.tplg file, other comments below.
There was a problem hiding this comment.
| add_dependencies(topology1 topology1_${output}) | |
| add_dependencies(topologies_v1 topology1_${output}) |
Please keep the plural here because it helps most people not familiar with CMake (and not trying to be)
There was a problem hiding this comment.
Unless there's going to be a different, abi_v2 target you probably want to keep this at the tools/topology level. I doubt you can define the same target twice.
There was a problem hiding this comment.
I cant do that. The outout ofthe get_abi.sh script is different for topology1 and topology2
There was a problem hiding this comment.
Should this be renamed to abi_v1 then? Just wondering. Sorry I forgot again what is the purpose of this, I mean which ABI it is. Add a comment?
There was a problem hiding this comment.
ther's only one ABI and its for the firmware. What should I say in the comment? that this is the firmware ABI?
There was a problem hiding this comment.
Two different formats for the same ABI, got it thanks for your patience.
There was a problem hiding this comment.
This looks like lying to CMake because the COMMAND does not create any final_${output}.tplg file.
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
Logic looks good. Sorry for nit-picking on the code style and symbol names but it's not like we have many full-time CMake experts in the project (none?) so reducing cognitive strain makes a significant difference.
There was a problem hiding this comment.
Should this be renamed to abi_v1 then? Just wondering. Sorry I forgot again what is the purpose of this, I mean which ABI it is. Add a comment?
fixed now. Thanks for your help! |
There was a problem hiding this comment.
Two different formats for the same ABI, got it thanks for your patience.
In preparation for Topology2.0, move the current topology files to the topology1 folder and once the 1.0 topologies are built copy them to the /sof/tools/build-tools/topology folder. When Topology2.0 topologies come along, they will be built into the topology2 folder and the 2.0 binaries will be copied over the 1.0 binaries. Signed-off-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com>
|
CI showing unrelated failure. |
In preparation for Topology2.0, move the current topology files
to the topology1 folder and once the 1.0 topologies are
built copy them to the /sof/tools/build-tools/topology folder.
When Topology2.0 topologies come along, they will be built into
the topology2 folder and the 2.0 binaries will be copied over
the 1.0 binaries.