Repository navigation
wait: print register values if poll_for_register_delay fails - #4251
Merged
Merged
Conversation
lgirdwood
reviewed
May 26, 2021
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Btw, I think there are other users of the poll() api who are not checking the result. Hence the error log in the bug.
Print register and its values if poll_for_register_delay fails. Also check the return value and print warning in sai.c and dw/dma.c. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
paulstelian97
approved these changes
May 26, 2021
Author
|
@lgirdwood @paulstelian97 added 1 warn to dw_dma, but I could not just find more without error checking... |
iuliana-prodan
approved these changes
May 26, 2021
lgirdwood
approved these changes
May 26, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Print register and its values if poll_for_register_delay fails. Also
check the return value and print warning in sai.c
Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com