Repository navigation
Conversation
There was a problem hiding this comment.
Yeah, I don't know how to control mclk/bclk separately...
There was a problem hiding this comment.
I would suggest that we add two helper functions to control mclk and bclk respectively. We count ref count in those helper functions. And we use the helper functions within ssp_set_clkctrl, ssp_port_stop, and ssp_port_start.
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Best to get inputs from @plbossart, @keyonjie and @slawblauciak
There was a problem hiding this comment.
this can just be called dai_clkctrl()
There was a problem hiding this comment.
Can we have a comment what this is used for ?
There was a problem hiding this comment.
I am thinking what should we do if we want to enable MCLK only?
There was a problem hiding this comment.
Dont think we need the union here as the interface looks generic.
There was a problem hiding this comment.
in fact, I would just put the
uint32_t clk_en; /**< Zero to disable the clock */
uint32_t clk_id; /**< Clock id to operate */in here directly
There was a problem hiding this comment.
dont think this struct is needed.
There was a problem hiding this comment.
lets keep it generic and remove "SSP" from these names.
There was a problem hiding this comment.
Can we not use "state" here, I'm assuming this needs to be in a configured but inactive state ?
There was a problem hiding this comment.
the state checking is added back.
|
@bardliao @keyonjie @RanderWang @mengdonglin fyi - please lets all help on the solution. |
|
Kernel PR is here: |
There was a problem hiding this comment.
I am thinking what should we do if we want to enable MCLK only?
There was a problem hiding this comment.
I would suggest that we add two helper functions to control mclk and bclk respectively. We count ref count in those helper functions. And we use the helper functions within ssp_set_clkctrl, ssp_port_stop, and ssp_port_start.
Add the SOF_IPC_DAI_CLKCTRL command for host to enable/disable DAI clocks explicitly. Signed-off-by: Brent Lu <brent.lu@intel.com>
|
Thanks @bardliao, we still need to figure our how to enable/disable mclk/bclk separately. In this test patch I just enable entire port and check the log to see if the IPC command works. |
|
@brentlu @lgirdwood I don't think it's required to add new IPCs for the current version of SOF, we can get by with what @bardliao is working on. It'd rather add this capability at a later stage when we have fewer in-flight IPC transitions on-going. |
|
closing since we've enabled the early bitclock support. |
Add the SOF_IPC_DAI_CLKCTRL command for host to enable/disable DAI
clocks explicitly.
Signed-off-by: Brent Lu brent.lu@intel.com