Skip to content

[WIP] codec_adapter: cadence: rework of reset & free procedures - #4162

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
mrajwa:ca_xrun_after_reset
May 25, 2021
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
mrajwa:ca_xrun_after_reset

Conversation

@mrajwa

@mrajwa mrajwa commented May 10, 2021

Copy link
Copy Markdown
Contributor

This patch fixes the reset procedure of cadence codecs.

Potential fix for #4104, not tested.

Signed-off-by: Marcin Rajwa marcin.rajwa@linux.intel.com

This patch fixes the reset procedure of cadence codecs.

Signed-off-by: Marcin Rajwa <marcin.rajwa@linux.intel.com>

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mrajwa looks like this should be for TGL13 and rc3 ?
@dbaluta any comments ?

@lgirdwood

Copy link
Copy Markdown
Member

@slawblauciak fyi - potential for TGL13

@mrajwa

mrajwa commented May 24, 2021

Copy link
Copy Markdown
Contributor Author

@lgirdwood yes lets include this patch

@dbaluta

dbaluta commented May 24, 2021

Copy link
Copy Markdown
Collaborator

@lgirdwood this should be OK.

@paulstelian97 can you please test this patch with imx-stable-v1.8 branch?

@lgirdwood

Copy link
Copy Markdown
Member

@paulstelian97 any update ?
@slawblauciak @mwasko @mrajwa fyi - could be needed for TGL13
@keyonjie for rc3.

@paulstelian97

Copy link
Copy Markdown
Collaborator

@paulstelian97 any update ?

Not quite yet, but from visual inspection I'm thinking on whether this needs some stress testing (I don't know if codec reset will reuse existing memory or not).

@keyonjie

Copy link
Copy Markdown
Contributor

@paulstelian97 any update ?
@slawblauciak @mwasko @mrajwa fyi - could be needed for TGL13
@keyonjie for rc3.

Okay, will back port it once merged.

@dbaluta

dbaluta commented May 25, 2021

Copy link
Copy Markdown
Collaborator

@lgirdwood @paulstelian97 @keyonjie I tested this patch and it doesn't do any harm. So, we can merge it. I have nothing against.

Anyhow, it doesn't fix #4104 or a related IMX issue. Where second cplay run fails. I'm investigating that on my side.

@paulstelian97 I will get back to you and hand over some codec_adapter IMX issues as next 2 weeks I will be in vacation.

@lgirdwood

Copy link
Copy Markdown
Member

@mrajwa do we need another fix for #4104 ?

@mrajwa

mrajwa commented May 25, 2021

Copy link
Copy Markdown
Contributor Author

@lgirdwood, I need to sync with @zrombel on that as the issue is only reproducable on a slim driver at the moment. I have it on my todo list so if the issue is not covered by this one I will submit another patch.

@lgirdwood

Copy link
Copy Markdown
Member

@lgirdwood, I need to sync with @zrombel on that as the issue is only reproducable on a slim driver at the moment. I have it on my todo list so if the issue is not covered by this one I will submit another patch.

Ok, could be another cause for #4104 but this is freeing the codec correctly so can be merged.

@lgirdwood
lgirdwood merged commit 479c09b into thesofproject:main May 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants