Skip to content

topology: sof-tgl-nocodec-ci: change to run smart_amp on core 1 - #4028

Merged
lgirdwood merged 1 commit into
thesofproject:mainfrom
keyonjie:multi_core
Apr 13, 2021
Merged

lgirdwood merged 1 commit into
thesofproject:mainfrom
keyonjie:multi_core

Conversation

@keyonjie

Copy link
Copy Markdown
Contributor

Change to run smart_amp pipelines on DSP core 1, this will help reduce
the core 0 usage and add multi-core to the CI coverage.

Signed-off-by: Keyon Jie yang.jie@linux.intel.com

Change to run smart_amp pipelines on DSP core 1, this will help reduce
the core 0 usage and add multi-core to the CI coverage.

Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
@lgirdwood

Copy link
Copy Markdown
Member

@keyonjie is the TGL CI expected to fail here ?

@plbossart

Copy link
Copy Markdown
Member

@keyonjie is the TGL CI expected to fail here ?

I think this is putting the cart before the horse. @keyonjie the premise of CI tests is that they are used for non-regressions. Here the multi-core does not work and will systematically throw an error, that's not useful. We need to enable this configuration when multi-core does work. Otherwise you will add noise to every PR review and decrease the attention people put on CI results.

@marc-hb

marc-hb commented Apr 13, 2021

Copy link
Copy Markdown
Collaborator

https://sof-ci.01.org/sofpr/PR4028/build8669/devicetest/ failed because TGLU_SKU0A32_SDCA was added to PR testing before being ready, sorry for the inconvenience. I removed it.

The other error is just the usual suspend/resume TIMEOUT

@marc-hb

marc-hb commented Apr 13, 2021

Copy link
Copy Markdown
Collaborator

SOFCI TEST

@lgirdwood

Copy link
Copy Markdown
Member

@marc-hb thanks for aligning us here and retesting.

@lgirdwood
lgirdwood merged commit cd2444a into thesofproject:main Apr 13, 2021
@keyonjie

Copy link
Copy Markdown
Contributor Author

yes @plbossart @lgirdwood @marc-hb , the TGLU-RVP-NOCODEC is not in the PR test model yet so we are not seeing error for PRs. It is in the daily pool so hopefully we will see it in today's daily report, we can add it to PR pool once the issue is fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants