Repository navigation
Conversation
This patch replaces use of pipe-volume-capture macro or pipe-low-latency-capture to pipe-volume-switch-capture in nocodec topologies for APL, BDW, CHT, CNL, ICL, and TGL based platforms. It allows to test of volume component mute switch control in SSP loopback that is used by default in nocodec topologies. The testing of mute switch feature is simplest to do with loopback topologies. Nocodec topologies are not in mainstream usage so this is the safest option to enable testing. The mute switch add should be possible to all capture topologies but it can be done later once it is confirmed it is safe to do (avoid accidental muted audio or problems with UCM). Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
@plbossart dont we use nocodec topologies on developer boards like UP^2 etc ?
|
@lgirdwood Yes, I'm using nocodec topologies in UP2 and Minnowboard when I have no audio peripherals hooked. Also it's practical to set nocodec mode via kconfig force nocodec option even if audio HW would be detected. I'm using such configuration for sof-test runs those rely on SSP LBM loopback. |
|
CI results look now OK with this topology change. The patch is the same but apparently the tests are now more robust. |
|
@plbossart any comments ? |
plbossart
left a comment
plbossart
left a comment
There was a problem hiding this comment.
The nocodec topologies used to be plain vanilla ones with no processing, it seems they are moving towards a more full-fledged topology. That's fine I guess.
|
BYT alsa bat signal overflow - unrelated since PR does not change BYT. |
4 participants
This patch replaces use of pipe-volume-capture macro or
pipe-low-latency-capture to pipe-volume-switch-capture in nocodec
topologies for APL, BDW, CHT, CNL, ICL, and TGL based platforms. It
allows to test of volume component mute switch control in SSP loopback
that is used by default in nocodec topologies. The testing of mute
switch feature is simplest to do with loopback topologies. Nocodec
topologies are not in mainstream usage so this is the safest option to
enable testing.
The mute switch add should be possible to all capture topologies but
it can be done later once it is confirmed it is safe to do (avoid
accidental muted audio or problems with UCM).
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com