Skip to content

interrupt: fix unsafe list del #368

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Sep 13, 2018
Merged

interrupt: fix unsafe list del #368

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/interrupt.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,12 +89,13 @@ static void irq_unregister_child(struct irq_desc *parent, int irq)
spin_lock(&parent->lock);
struct irq_desc *child;
struct list_item *clist;
struct list_item *tlist;

/* does child already exist ? */
if (list_is_empty(&parent->child[SOF_IRQ_BIT(irq)]))
goto finish;

list_for_item(clist, &parent->child[SOF_IRQ_BIT(irq)]) {
list_for_item_safe(clist, tlist, &parent->child[SOF_IRQ_BIT(irq)]) {
child = container_of(clist, struct irq_desc, irq_list);

if (SOF_IRQ_ID(irq) == child->id) {
Expand Down