Repository navigation
Conversation
When use MEU as sign tool, PRIVATE_KEK_OPTION should also use MEU_PRIVATE_KEY. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>
marc-hb
left a comment
marc-hb
left a comment
There was a problem hiding this comment.
This commit is called "fix TGL build with custom key" but people are already building TGL with custom keys! I think you missed the discussion in #3187 (comment)
I'm not blaming you: that discussion was long and confusing!
The long story short: the -k option should not be used with MEU. That's because -k would require more code in this script (not just this line) to support MEU correctly. Use -m and the new, pass-through environment variable instead as shown in #3187 (comment)
PRIVATE_KEY_OPTION='-DMEU_PRIVATE_KEY=...' ./xtensa-build-all.sh ...
I will submit a print_usage() fix instead.
Done in #3512 |
|
@marc-hb Oh, I did not notice the method you provide, but my fix here can solve the situation with different usage for key. Could you have a try? This will provide a unify method to build with custom key. |
|
I don't think a "unified" method using the same RIMAGE_PRIVATE_KEY name for both rimage and MEU is a good idea. I think |
When use MEU as sign tool, PRIVATE_KEK_OPTION should also use
MEU_PRIVATE_KEY.
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com