Skip to content

pipeline: add missing buffer locks/unlocks #3454

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Sep 25, 2020
Merged

pipeline: add missing buffer locks/unlocks #3454

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/audio/pipeline.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,6 +164,7 @@ static int pipeline_for_each_comp(struct comp_dev *current,
struct list_item *clist;
struct comp_buffer *buffer;
struct comp_dev *buffer_comp;
uint32_t flags;

/* run this operation further */
list_for_item(clist, buffer_list) {
Expand All @@ -186,10 +187,15 @@ static int pipeline_for_each_comp(struct comp_dev *current,

/* continue further */
if (ctx->comp_func) {
buffer_lock(buffer, &flags);
buffer->walking = true;
buffer_unlock(buffer, flags);

int err = ctx->comp_func(buffer_comp, buffer,
ctx, dir);
buffer_lock(buffer, &flags);
buffer->walking = false;
buffer_unlock(buffer, flags);
if (err < 0)
return err;
}
Expand Down