Repository navigation
build-tools.sh: fix wrong variable names as reported by shellcheck - #3365
Merged
Merged
Conversation
Missing quotes mostly, also some disable=SC2034 because "eval". Signed-off-by: Marc Herbert <marc.herbert@intel.com>
Easier to spot once all other shellcheck warnings have been fixed. Signed-off-by: Marc Herbert <marc.herbert@intel.com>
marc-hb
force-pushed
the
shellcheck-build-tools
branch
from
August 28, 2020 19:42
773e074 to
8e17af8
Compare
marc-hb
marked this pull request as ready for review
August 28, 2020 20:48
marc-hb
requested review from
aiChaoSONG,
dbaluta,
fredoh9,
ranj063 and
xiulipan
August 28, 2020 20:52
lgirdwood
approved these changes
Aug 29, 2020
Member
|
@marc-hb can you check CI, I'm guessing it's unrelated. |
Collaborator
Author
|
Not related, they don't use these scripts and have been unfortunately failing the same in other PRs. |
Member
|
@zrombel this seems unrelated - are we good to merge ? |
|
There was a platform issue. After rerun all tests result are green so this PR is good to merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
2 commits
Seriously, use shellcheck.
The only reason it's not in this travis yet is because I hate copy/paste
marc-hb/sof-test@faadb20a854834