Skip to content

pcm_converter: Reduce modulo operations #3357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 1 commit into from
Aug 27, 2020
Merged

pcm_converter: Reduce modulo operations #3357

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions src/audio/pcm_converter/pcm_converter_hifi3.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -480,7 +480,7 @@ static void pcm_convert_s24_to_s32(const struct audio_stream *source,
}

/* main loop processes 2 samples at a time */
for (i = 0; i < samples / 2; i++) {
for (i = 0; i < samples - 1; i += 2) {
/* set source as circular buffer */
pcm_converter_setup_circular(source);

Expand All @@ -498,7 +498,7 @@ static void pcm_convert_s24_to_s32(const struct audio_stream *source,
AE_SA64POS_FC(align_out, out);

/* no more samples to process */
if (!(samples % 2))
if (i == samples)
return;

/* set source as circular buffer */
Expand Down Expand Up @@ -570,7 +570,7 @@ static void pcm_convert_s32_to_s24(const struct audio_stream *source,
}

/* main loop processes 2 samples at a time */
for (i = 0; i < samples / 2; i++) {
for (i = 0; i < samples - 1; i += 2) {
/* set source as circular buffer */
pcm_converter_setup_circular(source);

Expand All @@ -589,7 +589,7 @@ static void pcm_convert_s32_to_s24(const struct audio_stream *source,
AE_SA64POS_FC(align_out, out);

/* no more samples to process */
if (!(samples % 2))
if (i == samples)
return;

/* set source as circular buffer */
Expand Down