Skip to content

README.md: remove misleading "Prerequisites" and "Build Instructions" - #3229

Merged
mmaka1 merged 1 commit into
thesofproject:masterfrom
marc-hb:shorter-README
Jul 31, 2020
Merged

mmaka1 merged 1 commit into
thesofproject:masterfrom
marc-hb:shorter-README

Conversation

@marc-hb

@marc-hb marc-hb commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator

The "Prerequisites" and "Build Instructions" sections are dangerously
incomplete: they don't say a word about toolchains. Someone on gitter
just wondered why they don't work. sof-docs is the reference now and
lucky us that's already the first thing at the top of the file so keep
that. Remove these two sections so their build commands stop tempting
readers to skip the link to the unfortunately longer but necessary
sof-docs instructions.

Signed-off-by: Marc Herbert marc.herbert@intel.com

The "Prerequisites" and "Build Instructions" sections are dangerously
incomplete: they don't say a word about toolchains. Someone on gitter
just wondered why they don't work. sof-docs is the reference now and
lucky us that's already the first thing at the top of the file so keep
that. Remove these two sections so their build commands stop tempting
readers to skip the link to the unfortunately longer but necessary
sof-docs instructions.

Signed-off-by: Marc Herbert <marc.herbert@intel.com>
@marc-hb

marc-hb commented Jul 23, 2020

Copy link
Copy Markdown
Collaborator Author

The rendered, new READE.md can be seen at Files Changed tab -> ... menu -> View File

We've also been working on a toolchain FAQ BTW, hopefully something this week.

@paulstelian97 paulstelian97 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these commands put somewhere else in the guide so we aren't forced to depend on the xtensa-build-all scripts? The commands are useful in the proper context.

@marc-hb

marc-hb commented Jul 24, 2020

Copy link
Copy Markdown
Collaborator Author

Are these commands put somewhere else in the guide so we aren't forced to depend on the xtensa-build-all scripts?

I think they are, please check: https://thesofproject.github.io/latest/getting_started/build-guide/build-from-scratch.html#incremental-builds

See similar concerns discussed in PR #3064

@cujomalainey

Copy link
Copy Markdown
Contributor

I'm pretty sure the CI failure is highly related to this change, we should definitely pay close attention to it 😉

@mmaka1
mmaka1 merged commit c74c29f into thesofproject:master Jul 31, 2020
@marc-hb
marc-hb deleted the shorter-README branch February 12, 2021 01:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants