Repository navigation
Conversation
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
Shouldn't there also be an -ETIMEDOUT or some similar error in case the clock still isn't on? DON'T SWITCH TO A CLOCK THAT ISN'T ON! (you won't have a chance to panic I think)
There was a problem hiding this comment.
Should be a platform macro (since it may be different on different CAVS platforms).
There was a problem hiding this comment.
Should be a platform macro (since it may be different on different CAVS platforms).
Hi @lgirdwood the platform specific stuff is already covered by PLATFORM_DEFAULT_DELAY.
There was a problem hiding this comment.
ok, but you should have a local macro then.
|
Thanks for feedback, @lgirdwood @paulstelian97 I will refine this PR after #3205 get merged as there may be conflict with changing the similar part. |
e0f4fe0 to
33206ab
Compare
|
@keyonjie look like you need to rebase - no hurry - lets do after CNY. |
db1ad24 to
e8194be
Compare
|
@lgirdwood @paulstelian97 updated now. |
paulstelian97
left a comment
paulstelian97
left a comment
There was a problem hiding this comment.
Looks good to me, but waiting for test results...
Try 20 times and exit if it keeps failed, trace error and not update the current_freq_idx for the failed case. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
|
@keyonjie If this PR is still applicable, please submit it again. |
Try 20 times and exit if it keeps failed to avoid dead loop.
Signed-off-by: Keyon Jie yang.jie@linux.intel.com