Repository navigation
atomic: ll_scheduler: Fix atomic implementation, return old value - #3151
Merged
Merged
Conversation
lgirdwood
requested changes
Jul 8, 2020
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Everything else looks good.
Member
There was a problem hiding this comment.
This should return "current" i.e. the value before the sucessful increment as the "ret" value may be stale if other threads are also incrementing the same atomic value.
Return value should be aligned with compiler builtins implementations, see https://gcc.gnu.org/onlinedocs/gcc-4.1.1/gcc/Atomic-Builtins.html Signed-off-by: Karol Trzcinski <karolx.trzcinski@linux.intel.com>
Member
|
Jenkins known issues. |
lgirdwood
approved these changes
Jul 9, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Return value should be aligned with compiler builtins implementations,
see https://gcc.gnu.org/onlinedocs/gcc-4.1.1/gcc/Atomic-Builtins.html
Signed-off-by: Karol Trzcinski karolx.trzcinski@linux.intel.com