Repository navigation
smart_amp: fix smart amplifier tplg - #3142
Conversation
4820ff9 to
43ac7af
Compare
bkokoszx
changed the title
There was a problem hiding this comment.
if we change bitclk to 12.288M, the container size should be changed to 32 correspondingly, @RDharageswari can you help to confirm with @ryans-lee what format should we use?
There was a problem hiding this comment.
@keyonjie
One question: if we have 12.288M clock, then we have 12.288M/48k = 256 available bits in frame. If we will use 25 container, we will have: 25 * 8 = 200 bits per frame, so SSP could be configured with 256-200=56 frame end padding. Are you sure that we should change also container size? Why we cannot use configuration with frame end padding?
There was a problem hiding this comment.
@keyonjie
I've updated this PR and changed bclk to 12288000 and container to 32 bits. Now, I think, configuration meets codec requirements: bclk/fclk = 256, container is 32 bit.
This commit changes SSP bclk rate from 9600000 to 12288000 ind ssp container to 32 bits order to fix glitch issue. Signed-off-by: Bartosz Kokoszko <bartoszx.kokoszko@linux.intel.com>
43ac7af to
588c9db
Compare
|
@plbossart any comments on the clock changes ? |
Sorry, I didn't see yesterday's comment in #3092 (comment) that this is a hardware requirement, so yes this should be merged. |
|
Lets rerun CI again now that device busy should be fixed. |
|
SOFCI TEST |
1 similar comment
|
SOFCI TEST |
|
@aiChaoSONG CI look like a gain issue again. This time too low that resulting in a fail. Again difficult to tell from sof-logger to find the PGAs. https://sof-ci.01.org/sofpr/PR3142/build6658/devicetest/ alsabat on CML fails. |
This commit changes SSP bclk rate from 9600000 to
12288000 ind ssp container to 32 bits order to fix
glitch issue.
fixes #3092
Signed-off-by: Bartosz Kokoszko bartoszx.kokoszko@linux.intel.com