Repository navigation
fix a DSP hang issue - #3140
Closed
keyonjie wants to merge 1 commit into
Closed
fix a DSP hang issue#3140keyonjie wants to merge 1 commit into
keyonjie wants to merge 1 commit into
Conversation
mmaka1
reviewed
Jul 7, 2020
There was a problem hiding this comment.
A similar issue is being solved by #3113 wrt HPRO requests in order to deal with unbalanced requests. There is a bitmap of clients requesting override. Similar thing would help here (dedicated bit for host_pg_override and another one for fw_pg_override). Then multiple unbalanced req/de-req does not cause issues.
lgirdwood
requested changes
Jul 7, 2020
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Please provide context in the PR title, it also looks like one patch is not related to a hang ?
keyonjie
force-pushed
the
tgl-007-drop-stable
branch
from
July 8, 2020 06:27
15f3423 to
b6f34d2
Compare
We should decrease the ref_cnt only when the DSP is active (dsp_d0_sref > 0), otherwise, consective PM_GATE IPC asking for enter PM GATE with different flags will lead to minus ref_cnt and the DSP won't be abled to activate from the PM_GATE with SOF_PM_PPG flag. Signed-off-by: Keyon Jie <yang.jie@linux.intel.com>
jajanusz
force-pushed
the
tgl-007-drop-stable
branch
3 times, most recently
from
July 14, 2020 20:06
be6c347 to
fb801c8
Compare
Contributor
Author
|
TGL-007 release was done so close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.