Repository navigation
pipe: remove waiti when task is cancelled - #314
Merged
Merged
Conversation
tlauda
suggested changes
Sep 6, 2018
Contributor
There was a problem hiding this comment.
wait can be removed from argument list.
Collaborator
Author
There was a problem hiding this comment.
yes, I will refine it.
Contributor
There was a problem hiding this comment.
Do we really need switch anymore? Maybe just simple if for TASK_STATE_QUEUED would be enough.
Collaborator
Author
There was a problem hiding this comment.
good idea. I keep it for future
RanderWang
force-pushed
the
waiti-1.2
branch
2 times, most recently
from
September 6, 2018 08:50
7f5823b to
1bfdb25
Compare
Two reasons: (1)waiti would cause FW panic if it is called in irq level higher than passive level (2)no need to wait cancelled task to be complete. Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com> Signed-off-by: Rander Wang <rander.wang@linux.intel.com>
Collaborator
Author
|
update my PR, thanks for review |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two reasons: (1)waiti would cause FW panic if it is called in irq level
higher than passive level (2)no need to wait cancelled task to be complete.
Signed-off-by: Pan Xiuli xiuli.pan@linux.intel.com
Signed-off-by: Rander Wang rander.wang@linux.intel.com