Skip to content

fix some potential bugs in scheduler #313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lgirdwood merged 2 commits into from
Sep 6, 2018
Merged

fix some potential bugs in scheduler #313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f517f75
schedule: fix edf reschedule
xiulipan Sep 6, 2018
8c3917d
schedule: fix schedule list double add
xiulipan Sep 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/lib/schedule.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,9 +141,11 @@ static inline struct task *edf_get_next(uint64_t current,
trace_pipe("ed!");

/* have we already tried to rescheule ? */
if (reschedule++)
if (!reschedule) {
reschedule++;
trace_pipe("edr");
edf_reschedule(task, current);
else {
} else {
/* reschedule failed */
list_item_del(&task->list);
task->state = TASK_STATE_CANCEL;
Expand Down Expand Up @@ -267,6 +269,13 @@ static int _schedule_task(struct task *task, uint64_t start, uint64_t deadline)
return 0;
}

/* is task already running ? - not enough MIPS to complete ? */
if (task->state == TASK_STATE_QUEUED) {
trace_pipe("tsq");
spin_unlock_irq(&sch->lock, flags);
return 0;
}

/* get the current time */
current = platform_timer_get(platform_timer);

Expand Down