Skip to content

topology: sdw: fix dmic issue on tgl sdw platforms - #2994

Merged
lgirdwood merged 1 commit into
thesofproject:masterfrom
RanderWang:dmic_sdw
Jun 1, 2020
Merged

lgirdwood merged 1 commit into
thesofproject:masterfrom
RanderWang:dmic_sdw

Conversation

@RanderWang

@RanderWang RanderWang commented May 29, 2020 •

Copy link
Copy Markdown
Collaborator

Port commit a716056 ("tgl: use additional CHANNEL
define in rt711 + rts1308 tplg") to all tgl sdw platforms

Signed-off-by: Rander Wang rander.wang@intel.com

Port commit a716056 ("tgl: use additional CHANNEL
define in rt711 + rts1308 tplg") to all tgl sdw platforms

Signed-off-by: Rander Wang <rander.wang@intel.com>
@RanderWang

Copy link
Copy Markdown
Collaborator Author

@ClarexZhou this is for DMIC issue

@lgirdwood lgirdwood left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@singalsu @bkokoszx any comments ?

@singalsu singalsu left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@plbossart plbossart left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how does the kernel select the 2 or 4ch topology? we currently don't have any mechanism to do so.

@RanderWang

Copy link
Copy Markdown
Collaborator Author

how does the kernel select the 2 or 4ch topology? we currently don't have any mechanism to do so.
we need to select the correct topology and remove the postfix of 2ch & 4ch.

@ClarexZhou ClarexZhou left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified issue #2991 can be fixed by this PR

@lgirdwood
lgirdwood merged commit 30e801c into thesofproject:master Jun 1, 2020
@plbossart

Copy link
Copy Markdown
Member

how does the kernel select the 2 or 4ch topology? we currently don't have any mechanism to do so.
we need to select the correct topology and remove the postfix of 2ch & 4ch.

how does the kernel select the 2 or 4ch topology? we currently don't have any mechanism to do so.
we need to select the correct topology and remove the postfix of 2ch & 4ch.

Oh man, that's really hard to maintain with a build that can support multiple options.

@RanderWang

RanderWang commented Jun 2, 2020 •

Copy link
Copy Markdown
Collaborator Author

how does the kernel select the 2 or 4ch topology? we currently don't have any mechanism to do so.
we need to select the correct topology and remove the postfix of 2ch & 4ch.

how does the kernel select the 2 or 4ch topology? we currently don't have any mechanism to do so.
we need to select the correct topology and remove the postfix of 2ch & 4ch.

Oh man, that's really hard to maintain with a build that can support multiple options.

@plbossart Actually I investigated this issue in kernel driver. We can check NHLT table but is it supported by coreboot ? Second now all NHLT related function are encapsulated by CONFIG_SND_SOC_SOF_HDA and the intel-nhlt.c is included in sound/hda. It is not suitable for SSP + DMIC only case or SDW + DMIC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants