Repository navigation
topology: align pipeline parameters with hardware configuration - #2886
Merged
Merged
Conversation
Collaborator
Author
|
Internal Intel CI tests failing are irrelevant, since this is a topology change. |
xiulipan
approved these changes
May 7, 2020
lgirdwood
requested changes
May 7, 2020
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Can you include "fix" in the commit subject. This way it stands out as a fix for stable branches.
slawblauciak
force-pushed
the
ehl_dmic_fix
branch
from
May 18, 2020 13:26
1e0b456 to
892c687
Compare
Collaborator
Author
|
Commit message changed. |
The stream parameters set in the pipeline were mismatched with the DMIC hardware configuration, which resulted in failures. Signed-off-by: Slawomir Blauciak <slawomir.blauciak@linux.intel.com>
slawblauciak
force-pushed
the
ehl_dmic_fix
branch
from
May 18, 2020 13:28
892c687 to
306ddb5
Compare
lgirdwood
approved these changes
May 18, 2020
Contributor
|
@slawblauciak Maybe you can also change the PCM id of PIPELINE_PCM_ADD() to align with PCM_PLAYBACK_ADD() |
Member
@slawblauciak @libinyang if this is a new bug then we can do a new PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stream parameters set in the pipeline were mismatched with
the DMIC hardware configuration, which resulted in failures.
Signed-off-by: Slawomir Blauciak slawomir.blauciak@linux.intel.com