Repository navigation
Topology: BDW, BYT, CHT: Reduce buffer size max for media PCM - #2574
Merged
lgirdwood merged 1 commit intoMar 20, 2020
Merged
Conversation
singalsu
requested review from
dbaluta,
jajanusz,
lbetlej,
mmaka1,
plbossart and
tlauda
as code owners
March 18, 2020 13:45
lgirdwood
approved these changes
Mar 18, 2020
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Can you do this for all CHT, BSW topologies too.
Collaborator
Author
|
I realized now that this change impacts APT, BDW, BYT, and CHT. I need to edit the commit message since I though it was only for BYT. |
singalsu
force-pushed
the
byt_tplg_pcm_buffer_size
branch
from
March 18, 2020 15:14
44b29a5 to
42426e4
Compare
singalsu
changed the title
lgirdwood
reviewed
Mar 18, 2020
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
No impact to APL since it does not use compressed page descriptors (i.e. the page table IPC logic).
singalsu
force-pushed
the
byt_tplg_pcm_buffer_size
branch
from
March 19, 2020 11:50
42426e4 to
c14e5c2
Compare
Member
|
@singalsu commit message still says APL |
This change prevents the IPC error that happens if aplay or speaker-test uses larger than 64 kB buffer size. The buffer setting in PCM_CAPABILITIES() is now the same as for low latency PCM. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
force-pushed
the
byt_tplg_pcm_buffer_size
branch
from
March 20, 2020 08:39
c14e5c2 to
6bd4553
Compare
singalsu
changed the title
Collaborator
Author
|
Thanks, I've now fixed the commit message. |
Member
|
Jenkins CI known issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change prevents the IPC error that happens if aplay or
speaker-test uses larger than 64 kB buffer size. The buffer
setting in PCM_CAPABILITIES() is now the same as for low latency
PCM.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com