Repository navigation
hda-dma: refactor xrun handling - #2512
Merged
Merged
Conversation
tlauda
requested review from
dbaluta,
jajanusz,
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
March 10, 2020 09:30
This was referenced Mar 10, 2020
lgirdwood
reviewed
Mar 10, 2020
Contributor
Author
There was a problem hiding this comment.
@lgirdwood Yes, but have different names depends on the stream's direction. It's just cosmetic change.
Member
There was a problem hiding this comment.
ok, can you comment this otherwise it may confuse.
Changes behaviour of HDA Link overruns and underruns handling. Let's no longer stop the stream, but just report an error. It might happen that just after the release buffer is still full/not yet empty after the previous run, but it shouldn't affect the data, since stream has been paused anyway. Also adds additional bit to better reflect hardware registers. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
force-pushed
the
topic/hda-link-fixes
branch
from
March 10, 2020 10:55
13288ae to
e954709
Compare
lgirdwood
approved these changes
Mar 10, 2020
jajanusz
approved these changes
Mar 11, 2020
Contributor
|
false positives in CI, sof logger abi mismatch, unrelated |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes behaviour of HDA Link overruns and underruns handling.
Let's no longer stop the stream, but just report an error.
It might happen that just after the release buffer is still
full/not yet empty after the previous run, but it shouldn't
affect the data, since stream has been paused anyway.
Also adds additional bit to better reflect hardware registers.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com