Repository navigation
ipc: dai: remove unused hdr field in params - #2417
Merged
Merged
Conversation
lgirdwood
approved these changes
Feb 20, 2020
ranj063
approved these changes
Feb 20, 2020
Member
|
SOFCI TEST |
1 similar comment
Member
|
SOFCI TEST |
Member
|
Rerun CI with latest CI fixes. |
lgirdwood
reviewed
Feb 28, 2020
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Given the CI results I'm thinking this is being used somewhere via pointer arithmetic and a cast ?
Member
Author
well duh, the unused header is just a single u32, not an array of 2 as I was told before... |
We don't use this field, move back to reserved. Signed-off-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
plbossart
force-pushed
the
fix/ipc-hdr
branch
from
February 28, 2020 21:43
5071036 to
27e6d56
Compare
Member
|
So it is, the naming is very similar for both headers. Not sure why it's flagging up on internal CI fir WHL though so lets rerun. |
Member
|
SOFCI TEST |
Member
Author
|
CI tests are ok, and checkpatch.pl errors are 'normal'. Anything you need from me @lgirdwood ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't use this field, move back to reserved.
Signed-off-by: Pierre-Louis Bossart pierre-louis.bossart@linux.intel.com