Repository navigation
work: add work_queue to core_context - #237
Merged
lgirdwood merged 1 commit intoAug 21, 2018
Merged
Conversation
Implements work_queue per core by adding it to core_context. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
lgirdwood
reviewed
Aug 20, 2018
| #include <arch/cpu.h> | ||
| #include <sof/work.h> | ||
|
|
||
| struct work_queue **arch_work_queue_get(void) |
Member
There was a problem hiding this comment.
Also, could this be static inline ?
Contributor
Author
There was a problem hiding this comment.
- ** to be able to assign pointer per core using the same init function.
It's the same as of other core_context members. - It could be problematic as implementation is in .c files and for up needs to access static struct.
Member
There was a problem hiding this comment.
Sorry, not following 1. Are you saying there there would be differences to init function on each core without this ?
Contributor
Author
|
What I meant is that work queue init function assigns address to the work queue struct pointer (allocation on runtime heap). I'm returning pointer to a pointer to allow address assignment in a more conveniant way by using local variable. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements work_queue per core by adding it to core_context.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com