Repository navigation
Topology: Apply high-pass filter to rt715 capture pipelines - #2302
Merged
lgirdwood merged 1 commit intoJan 21, 2020
Merged
Conversation
This patch mitigates the start transient in capture from rt715 codec. The start transient is DC pulse that can be attenuated significantly with a high-pass filter. The pipeline macro pipe-highpass-capture.m4 adds a 40 Hz second order IIR filter into the beginning of pipeline. The volume control in this pipeline is also set to a longer 400 ms ramp length (normally 250 ms) that is sufficient to conceal PCM waveform issues before the IIR filter settles to DC level. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
paulstelian97
approved these changes
Jan 17, 2020
paulstelian97
left a comment
paulstelian97
left a comment
Collaborator
There was a problem hiding this comment.
Approved for I have seen the waveform on the Linux issue, seems to fix it.
lgirdwood
approved these changes
Jan 17, 2020
plbossart
approved these changes
Jan 17, 2020
Collaborator
Author
|
SOFCI TEST |
Member
|
@zrombel can you comment on the scan. Thanks. |
|
First code check failed because of server error. Right now every thing passed. |
Member
|
@zrombel thanks ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch mitigates the start transient in capture from rt715
codec. The start transient is DC pulse that can be attenuated
significantly with a high-pass filter. The pipeline macro
pipe-highpass-capture.m4 adds a 40 Hz second order IIR filter
into the beginning of pipeline. The volume control in this pipeline
is also set to a longer 400 ms ramp length (normally 250 ms) that
is sufficient to conceal PCM waveform issues before the IIR filter
settles to DC level.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com