Repository navigation
Volume: Avoid unnecessary error trace about limiting to VOL_MIN - #2272
Merged
Merged
Conversation
The trace issue is only cosmetic since VOL_MIN is currently defined to zero. There linear gain value was not altered despite the emitted trace. With this change the limiting no more happens for input value zero. The related trace messages are improved to show the defined limits for easier adjust the offending topology volume scale if this happens. The string split style is also updated to current. Signed-off-by: Seppo Ingalsuo <seppo.ingalsuo@linux.intel.com>
singalsu
requested review from
dbaluta,
jajanusz,
lbetlej,
mmaka1,
plbossart and
tlauda
as code owners
January 10, 2020 11:42
Collaborator
Author
|
The SOF issue is #2271. |
paulstelian97
approved these changes
Jan 10, 2020
dbaluta
reviewed
Jan 10, 2020
Collaborator
Author
|
SOFCI TEST |
lgirdwood
approved these changes
Jan 10, 2020
mmaka1
approved these changes
Jan 10, 2020
Collaborator
Author
|
Great, thanks @dbaluta , @paulstelian97 , @mmaka1 and @lgirdwood for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The trace issue is only cosmetic since VOL_MIN is currently defined
to zero. There linear gain value was not altered despite the emitted
trace. With this change the limiting no more happens for input value
zero.
The related trace messages are improved to show the defined limits
for easier adjust the offending topology volume scale if this
happens. The string split style is also updated to current.
Signed-off-by: Seppo Ingalsuo seppo.ingalsuo@linux.intel.com