Skip to content

Fix BDW DMA timer - #2188

Merged
lgirdwood merged 2 commits into
thesofproject:masterfrom
xiulipan:pr/bdwfix
Dec 16, 2019
Merged

lgirdwood merged 2 commits into
thesofproject:masterfrom
xiulipan:pr/bdwfix

Conversation

@xiulipan

Copy link
Copy Markdown
Contributor

Fix BDW DMA timer.
Fix typo in BDW SSP issue.

Thanks @tlauda to help debug the timer issue.
Fix #2096

BDW DMAC0 can not be used with scheduler and no-one used it. The DMA
chan is not initiated and may cause DSP hang when read null point.
Skip the DMAC0 to avoid such issue.

Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I have minor comment to commit message of the second patch.

Comment thread src/platform/haswell/platform.c Resolved
SSP clock on BDW is 24MHz.

Signed-off-by: Pan Xiuli <xiuli.pan@linux.intel.com>

@kv2019i kv2019i left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @xiulipan , looks good.

@RanderWang RanderWang left a comment •

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I don't know when DMA0 is used. One year ago, it is not used for hw requirement.

@jajanusz

Copy link
Copy Markdown
Contributor

SOFCI TEST

@lgirdwood

Copy link
Copy Markdown
Member

CI usual suspects.

@lgirdwood
lgirdwood merged commit d9be34d into thesofproject:master Dec 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] IPC timeout on BDW

6 participants