Repository navigation
Topology: Fix DAI_ADD function call in sof-cml-rt1011-rt5682 topology - #2151
Merged
lgirdwood merged 1 commit intoNov 28, 2019
Merged
Conversation
Contributor
Author
|
Should fix #2107 |
wwittbrx
force-pushed
the
cml-rt1011-rt5682_topology_fix
branch
from
November 28, 2019 09:39
629e661 to
6abdb78
Compare
wwittbrx
force-pushed
the
cml-rt1011-rt5682_topology_fix
branch
from
November 28, 2019 09:46
6abdb78 to
4db75d1
Compare
This patch fixes DAI_ADD function call for speaker pipeline. The function call had incorrect number of agruments passed which was causing issues with playback. Signed-off-by: WojciechX Wittbrodt <wojciechx.wittbrodt@intel.com>
wwittbrx
force-pushed
the
cml-rt1011-rt5682_topology_fix
branch
from
November 28, 2019 09:50
4db75d1 to
8b6faf0
Compare
Contributor
|
Thanks for the fix. |
lgirdwood
approved these changes
Nov 28, 2019
lgirdwood
left a comment
lgirdwood
left a comment
Member
There was a problem hiding this comment.
Good catch, I've grepped and there are no others.
lbetlej
approved these changes
Nov 28, 2019
Contributor
|
Hi, This change wont impact the issue we are seeing with 008. Can we look at why the issue is on 008. |
Contributor
|
@sathyap-chrome We need this fix for no sound on 008 issue, @aiChaoSONG is fixing the no sound issue with an extra kernel patch, good news is that it is done, PR will be sent out soon. |
Contributor
|
great thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch fixes DAI_ADD function call for speaker pipeline.
The function call had incorrect number of agruments passed which was causing issues with playback.