Repository navigation
ipc: add complete task callback - #1887
Merged
Merged
Conversation
Changes priority of IPC and IDC tasks. They are always scheduled as EDF tasks, where order of scheduling is based on deadline and priority is meant for special tasks e.g. IDLE or ALMOST_IDLE. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Contributor
Author
|
@wenqingfu @mengdonglin @aiChaoSONG Should fix #1812 and #1830. |
tlauda
force-pushed
the
topic/edf-fixes
branch
from
September 30, 2019 12:41
da55438 to
9c9f34c
Compare
tlauda
force-pushed
the
topic/edf-fixes
branch
from
September 30, 2019 14:22
9c9f34c to
d9fc281
Compare
Renames task's func to run to better show intention of this callback. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Adds complete callback to task. Some EDF tasks will need to have additional callback on task completion, which will be executed in critical section along the setting task state to complete. Doing it during regular execution is not enough, because it's done on passive level and we want to avoid any race condition. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Change the waiti implementation to panic only if we're lowering current interrupt level. In some rare cases (like entering D3 for some platforms) we don't care, because DSP will be disabled anyway. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Changes ipc task implementation, so it accepts new messages from host in a complete task callback. This way we will avoid the situation, where host will send another message before we truly complete current ipc task. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Removes host_pending from ipc structure, because it's no longer needed. Scheduler will automatically throw an error, when we'll try to run not completed task. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
Cleanups ipc functions, so we don't have many not needed layers of execution. Signed-off-by: Tomasz Lauda <tomasz.lauda@linux.intel.com>
tlauda
force-pushed
the
topic/edf-fixes
branch
from
October 1, 2019 06:18
d9fc281 to
417f771
Compare
Collaborator
|
@tlauda let me give it a try today |
Contributor
Author
|
SOFCI TEST |
dbaluta
approved these changes
Oct 1, 2019
Collaborator
Contributor
Author
|
SOFCI TEST |
This was referenced Oct 1, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes ipc task implementation, so it accepts new messages from
host in a complete task callback. This way we will avoid the
situation, where host will send another message before we
truly complete current ipc task.
Signed-off-by: Tomasz Lauda tomasz.lauda@linux.intel.com