Repository navigation
pipeline: fix period frame size calculation - #1773
Merged
Merged
Conversation
juimonen
requested review from
lbetlej,
lgirdwood,
mmaka1 and
plbossart
as code owners
August 28, 2019 15:04
tlauda
approved these changes
Aug 28, 2019
tlauda
suggested changes
Aug 28, 2019
Contributor
There was a problem hiding this comment.
#include <sof/math/numbers.h>
Author
There was a problem hiding this comment.
I thinks it is coming from component.h... so do you want me to include it explicitly to pipeline.h?
Contributor
There was a problem hiding this comment.
Yes, the best practice is to include headers explicitly, so you won't be surprised during refactor.
The period frame size calculation has issues by doing division instead of multiplication. So fix this by introducing new function for buffer period frames calculation where we multiply samplerate and schedule_period and divide by 1000000. Also round up the result. Signed-off-by: Jaska Uimonen <jaska.uimonen@intel.com>
tlauda
approved these changes
Aug 29, 2019
Contributor
|
I can confirm that this PR fixes bug #1772. |
jajanusz
approved these changes
Aug 30, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The period frame size calculation has issues by doing division instead
of multiplication. So fix this by introducing new function for buffer
period frames calculation where we multiply samplerate and
schedule_period and divide by 1000000. Also round up the result.
Signed-off-by: Jaska Uimonen jaska.uimonen@intel.com