Repository navigation
Conversation
|
@akloniex, can you provide an example use case in which we may need additional callbacks? |
|
@mrajwa I'm currently working on new DAI and DMA types, which will be used for Echo Reference Signal capturing, as well as Probing in the future. In these usecases we might need callbacks for 'regular' use, as we do now, and also notify this new DMA about buffer's life cycle updates. |
|
@akloniex Please update unit tests (in the same commit) |
There was a problem hiding this comment.
list_for_item is enough, since we don't remove anything from the list.
There was a problem hiding this comment.
We're not removing anything from the list at the moment, but we cannot guarantee that we won't do that in the future.
I've changed that, but we need to be careful if we ever try to remove items from the list, as we might in case of freeing the buffer.
There was a problem hiding this comment.
This piece of code is used multiple times, so it would be better to extract it to some inline function.
There was a problem hiding this comment.
Calling CBs extracted to separate function.
There was a problem hiding this comment.
It should be kept and done internally in the buffer.
Component should be able to just call buffer_set_cb and the whole allocation and adding to the list operations should be handled by buffer itself.
There was a problem hiding this comment.
@tlauda The way it's setup now, we don't need any dynamic allocations, as callback objects are members of components. I'm not sure if it's a good idea to allocate callbacks separately, as it would cause memory waste with each allocation overhead.
I agree, that it would be easier to register, and probably would look more pleasing, but I have my concerns about memory. If you think that should be changed anyway, then I'll adjust my PR.
There was a problem hiding this comment.
This should be the part of buffer_set_cb function with additional callback allocation logic.
cb46894 to
92e821a
Compare
|
@jajanusz UT fixed. |
In order to allow multiple callbacks registered to single buffer component, buffer_callback structure is created and list of callbacks nested into comp_buffer. Signed-off-by: ArturX Kloniecki <arturx.kloniecki@linux.intel.com>
|
SOFCI TEST |
lgirdwood
left a comment
lgirdwood
left a comment
There was a problem hiding this comment.
Need to have some locking around list manipulation since buffer callbacks could be triggered via IPC or via another core.
| static inline void buffer_add_callback(struct comp_buffer *buffer, | ||
| struct buffer_callback *cb) | ||
| { | ||
| list_item_append(&cb->list, &buffer->callback_list); |
|
Reimplementation in #1950. |
In order to allow multiple callbacks registered to single buffer
component, buffer_callback structure is created and list of callbacks
nested into comp_buffer.
Signed-off-by: ArturX Kloniecki arturx.kloniecki@linux.intel.com